Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign | Mobile Typography #1776

Closed
fongcindy opened this issue Sep 5, 2024 · 4 comments · Fixed by #1962
Closed

Redesign | Mobile Typography #1776

fongcindy opened this issue Sep 5, 2024 · 4 comments · Fixed by #1962
Assignees
Labels
V1 Final V1 handoff work
Milestone

Comments

@fongcindy
Copy link
Collaborator

Description

Changes to typography and type scale for mobile.
Ernesto will make slight changes from desktop to mobile format

User Story

No response

Acceptance Criteria

No response

@ErnestoFernandezAlvarez
Copy link
Collaborator

@fongcindy @gscottqueen

Attached is the Mobile type scale for the Benefit Finder.
For now I just added it next the Desktop version on the Hand off to devs page.

Note: all the fonts have been reduced for Mobile, except for the fonts used on CTA's which is 17.6pt for both Desktop and Mobile, therefore all buttons should be used for mobile as well (according to client)

If we need to further tweak the scale when we see it applied to wireframes, I will let you know and update the file accordingly.
Group 1205

https://www.figma.com/design/xij2PUZTouE6cco8f1F2Bn/ReDesign-Benefit-Finder?node-id=1033-1171&t=alMBNXy4wVXlA5E2-1

@scottqueen-bixal
Copy link
Collaborator

this hasn't been implemented on mobile yet, did I miss an update?

@ErnestoFernandezAlvarez
Copy link
Collaborator

Good morning @scottqueen-bixal, last time I checked in with @fongcindy about the mobile typescale, it seemed that it was ready to get implemented, however I don't know how it was prioritized for your area.

I am currently working on the mobile screens and will apply to type scale, I think you are working ahead of me.

This is the link to the file (the files are now under GSA's PX portfolio, they are the admin now):
https://www.figma.com/design/3qui91uX0iE4YMNrnx4gzK/ReDesign-Benefit-Finder?node-id=16-2035&t=m7sKURg5ZsauvGTt-1

@fongcindy
Copy link
Collaborator Author

Let's combine this with #1837, Do not close, unless #1837 is closed. Will make sure that the Mobile screens captures mobile typography.
@ErnestoFernandezAlvarez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V1 Final V1 handoff work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants