Allow specifying the running security groups for a space #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to a draft while I think through how this is working (or not) in an example app |
|
This is ready to go - opening up a new issue to maybe do one day about splitting out the ASG and user permissions stuff into a separate space-config module to use it for externally-created spaces. |
|
Does this have anything to do with the issue you're maybe having with |
Yeah, this is not currently working properly |
|
Blocked on cloudfoundry-community/terraform-provider-cloudfoundry#575 being resolved |
|
Closing this PR in favor of using the new cloudfoundry terraform provider for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Addresses issue: #52
closes #52
🛠 Summary of changes
Enables passing a list of security group names that should be applied to running apps in the space. Default is current behavior of only having
dnsapplied.