Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗒️ send a custom logger to the retryable HTTP client #21

Open
1 task
jadudm opened this issue Nov 11, 2024 · 0 comments
Open
1 task

🗒️ send a custom logger to the retryable HTTP client #21

jadudm opened this issue Nov 11, 2024 · 0 comments

Comments

@jadudm
Copy link
Collaborator

jadudm commented Nov 11, 2024

At a glance

In order to keep things quiet
as a developer
I want the ability to control the logging of my application

Acceptance Criteria

We use DRY behavior-driven development wherever possible.

then...

Shepherd

  • UX shepherd:
  • Design shepherd:
  • Engineering shepherd:

Background

On every fetch we are currently logging to STDOUT, because the http.Client in the retryable package is sending DEBUG-level messages.

We might want that... or we might want. That could mean ~25M log lines/month, which we do not necessarily want.

This should follow the app-wide logger, and only send info.

Security Considerations

Required per CM-4.

We need to log as part of our SSP/compliance work, but we also want to log what makes sense. Logging everything that we fetch is not necessary, because it shows up in the end product. (For debugging, we want it... not for production.) So, getting this disabled matters for production use.


Process checklist
  • Has a clear story statement
  • Can reasonably be done in a few days (otherwise, split this up!)
  • Shepherds have been identified
  • UX youexes all the things
  • Design designs all the things
  • Engineering engineers all the things
  • Meets acceptance criteria
  • Meets QASP conditions
  • Presented in a review
  • Includes screenshots or references to artifacts
  • Tagged with the sprint where it was finished
  • Archived

If there's UI...

  • Screen reader - Listen to the experience with a screen reader extension, ensure the information presented in order
  • Keyboard navigation - Run through acceptance criteria with keyboard tabs, ensure it works.
  • Text scaling - Adjust viewport to 1280 pixels wide and zoom to 200%, ensure everything renders as expected. Document 400% zoom issues with USWDS if appropriate.
@jadudm jadudm added this to jemison Nov 11, 2024
@github-project-automation github-project-automation bot moved this to triage in jemison Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: triage
Development

No branches or pull requests

1 participant