Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move constants to the RadeonRays namespace #200

Open
qhaas opened this issue Nov 27, 2018 · 0 comments
Open

Move constants to the RadeonRays namespace #200

qhaas opened this issue Nov 27, 2018 · 0 comments

Comments

@qhaas
Copy link

qhaas commented Nov 27, 2018

Recently, had a 'PI' collision between the one defined in RadeonRays and another sourcebase (which was using 'PI' as a namespace). While an #undef PI easily solved the issue, moving such (commonly named) constants to the RadeonRays namespace by way of a const might save future developers trouble.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qhaas