Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken lanczos mask using clang16 #129

Open
Nomoresleep opened this issue Apr 2, 2024 · 0 comments
Open

Broken lanczos mask using clang16 #129

Nomoresleep opened this issue Apr 2, 2024 · 0 comments

Comments

@Nomoresleep
Copy link

OS: Arch-Linux
Compiler: clang16 (blobbed)

Description:
When running the lanczos function from ffx_fsr2.cpp clang uses an integer based version of abs and implicitly converts the value argument to an integer format using cvtss2si and back to float with cvtsi2ss afterwards. This causes the full lanczos kernel mask to be basically useless, turning FSR output into a blur.

Resolution: It should probably use absf instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant