Add mismatches cache to improve performance on ultra-long reads #4651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here is a summary of the problem in google slide form
When each block renders, the renderer e.g. PileupRenderer requests features using the data adapters getFeatures method
Currently, the BAM library (@gmod/bam) has a feature cache to avoid re-requesting from the actual remote file each time, but JBrowse 2 re-creates new instances of e.g. the BamSlightlyLazyFeature from scratch each time.
This leads to duplicated computation of e.g. the "mismatches" on BAM and CRAM are not cached across blocks. This particularly affects long reads
This PR adds a method to cache the mismatches object by making a simple LRU cache that avoids re-creating an already created feature. it is not an "async LRU" so it is easy to reason about