-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save track data method on base track model #3439
base: main
Are you sure you want to change the base?
Conversation
tried making a minimal genbank export here https://github.com/GMOD/jbrowse-components/tree/save_track_data_genbank i'm not really fully in-the-know about how genbank works but the steps for this export are
this means the sequence exported is only that which spans the features in question. this is inspired by looking at this sample genbank record https://www.ncbi.nlm.nih.gov/Sitemap/samplerecord.html which refers to a sequence of about 5kb from 1..5028, but is actually in the middle of chrIX on yeast https://yeastgenome.org/locus/S000001402/sequence that led me to subtract everything relative to this currently viewed region. the alternative would be exporting the entire chromosome sequence (which can be large) and then using true start/end coords. cc @scottcain xref https://community.alliancegenome.org/t/genbank-format-downloading-from-jbrowse1-2/6772/4 |
37df522
to
979e476
Compare
991e10f
to
d269640
Compare
added some genbank export to this branch also downloaded snapgene free trial. the exports from this branch look approximately similar to a gbrowse genbank exports made from maizemine Example |
e379584
to
66981c0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3439 +/- ##
==========================================
- Coverage 62.61% 62.14% -0.47%
==========================================
Files 1088 1096 +8
Lines 31495 31696 +201
Branches 7531 7565 +34
==========================================
- Hits 19721 19699 -22
- Misses 11602 11824 +222
- Partials 172 173 +1 ☔ View full report in Codecov by Sentry. |
66981c0
to
1f496f0
Compare
1f496f0
to
ee82b1d
Compare
2f01c56
to
35262ef
Compare
Added a bug report for GFF3 generation in that it doesn't produce a ##sequence-region directive: #3679 |
Added a bug report for GFF3 production that it gets strand wrong (1 or -1 instead of the standard + or -): #3678 |
Added a feature request to have the location info embedded in saved track data filenames: #3680 |
bdccbd2
to
fc9e258
Compare
fc9e258
to
024fac2
Compare
updated to latest main at v2.6.2 @scottcain |
024fac2
to
1de51c9
Compare
1de51c9
to
ace1459
Compare
new work trying to push this forward a little bit that makes the set of file formats part of the track model. could also look at display model and/or adapter model potentially, but this is a step towards a little less hardcoded format |
f58a40c
to
a3d5aaf
Compare
address comment here #4029 (comment) |
a3d5aaf
to
a2ac301
Compare
a2ac301
to
f477113
Compare
f477113
to
8027bd8
Compare
8027bd8
to
75f2e0c
Compare
338a778
to
5258e84
Compare
5258e84
to
082f6ae
Compare
f526a1c
to
10a6cca
Compare
10a6cca
to
83cbc05
Compare
83cbc05
to
bf245c3
Compare
42cd6a2
to
f51bb83
Compare
f51bb83
to
02e99a1
Compare
c2f7229
to
bf34073
Compare
bf34073
to
d7c7ca6
Compare
8708cf4
to
880efb8
Compare
880efb8
to
3daccbe
Compare
8bf2361
to
23fe569
Compare
bfb3dba
to
0da7129
Compare
0da7129
to
b1ce075
Compare
This adds a basic concept of performing a "save track data" function on the base track model
xref #3094
It attempts to export all feature types as GFF3 for the currently visible region right now
It downloads the features to the main thread and makes a best effort to translate them into GFF3 format
As noted in the title, the "Save track data" feature is on the "Base track model". this is a bit awkward and currently accesses the "dynamic blocks of the view". this could suggest that this feature should be placed on the display model instead, or have some other way of obtaining regions