From 6ce076c633b9e130f42a387be0441d54724bab4e Mon Sep 17 00:00:00 2001
From: Garrett Stevens <stevens.garrett.j@gmail.com>
Date: Wed, 3 Feb 2021 13:44:21 -0700
Subject: [PATCH] Move "mouseover" config from base to basic display

---
 .../ConfigurationEditor.test.js.snap          | 72 +++++++++----------
 .../models/baseLinearDisplayConfigSchema.ts   |  8 ---
 .../src/LinearBasicDisplay/configSchema.ts    | 12 +++-
 3 files changed, 47 insertions(+), 45 deletions(-)

diff --git a/plugins/config/src/ConfigurationEditorWidget/components/__snapshots__/ConfigurationEditor.test.js.snap b/plugins/config/src/ConfigurationEditorWidget/components/__snapshots__/ConfigurationEditor.test.js.snap
index 839bf50081..fad3568413 100644
--- a/plugins/config/src/ConfigurationEditorWidget/components/__snapshots__/ConfigurationEditor.test.js.snap
+++ b/plugins/config/src/ConfigurationEditorWidget/components/__snapshots__/ConfigurationEditor.test.js.snap
@@ -711,6 +711,42 @@ exports[`ConfigurationEditor widget renders with defaults of the PileupTrack sch
   class="makeStyles-root"
   data-testid="configEditor"
 >
+  <div
+    class="MuiPaper-root makeStyles-paper MuiPaper-elevation1 MuiPaper-rounded"
+  >
+    <div
+      class="makeStyles-paperContent"
+    >
+      <div
+        class="MuiFormControl-root MuiTextField-root"
+      >
+        <label
+          class="MuiFormLabel-root MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-shrink MuiFormLabel-filled"
+          data-shrink="true"
+        >
+          maxDisplayedBpPerPx
+        </label>
+        <div
+          class="MuiInputBase-root MuiInput-root MuiInput-underline MuiInputBase-formControl MuiInput-formControl"
+        >
+          <input
+            aria-invalid="false"
+            class="MuiInputBase-input MuiInput-input"
+            type="number"
+            value="1.7976931348623157e+308"
+          />
+        </div>
+        <p
+          class="MuiFormHelperText-root MuiFormHelperText-filled"
+        >
+          maximum bpPerPx that is displayed in the view
+        </p>
+      </div>
+    </div>
+    <div
+      class="makeStyles-slotModeSwitch"
+    />
+  </div>
   <div
     class="MuiPaper-root makeStyles-paper MuiPaper-elevation1 MuiPaper-rounded"
   >
@@ -875,42 +911,6 @@ exports[`ConfigurationEditor widget renders with defaults of the PileupTrack sch
       </button>
     </div>
   </div>
-  <div
-    class="MuiPaper-root makeStyles-paper MuiPaper-elevation1 MuiPaper-rounded"
-  >
-    <div
-      class="makeStyles-paperContent"
-    >
-      <div
-        class="MuiFormControl-root MuiTextField-root"
-      >
-        <label
-          class="MuiFormLabel-root MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-shrink MuiFormLabel-filled"
-          data-shrink="true"
-        >
-          maxDisplayedBpPerPx
-        </label>
-        <div
-          class="MuiInputBase-root MuiInput-root MuiInput-underline MuiInputBase-formControl MuiInput-formControl"
-        >
-          <input
-            aria-invalid="false"
-            class="MuiInputBase-input MuiInput-input"
-            type="number"
-            value="1.7976931348623157e+308"
-          />
-        </div>
-        <p
-          class="MuiFormHelperText-root MuiFormHelperText-filled"
-        >
-          maximum bpPerPx that is displayed in the view
-        </p>
-      </div>
-    </div>
-    <div
-      class="makeStyles-slotModeSwitch"
-    />
-  </div>
   <label
     class="MuiFormLabel-root"
   >
diff --git a/plugins/linear-genome-view/src/BaseLinearDisplay/models/baseLinearDisplayConfigSchema.ts b/plugins/linear-genome-view/src/BaseLinearDisplay/models/baseLinearDisplayConfigSchema.ts
index d0993107e2..a2d8c4c80d 100644
--- a/plugins/linear-genome-view/src/BaseLinearDisplay/models/baseLinearDisplayConfigSchema.ts
+++ b/plugins/linear-genome-view/src/BaseLinearDisplay/models/baseLinearDisplayConfigSchema.ts
@@ -3,14 +3,6 @@ import { ConfigurationSchema } from '@jbrowse/core/configuration'
 export const baseLinearDisplayConfigSchema = ConfigurationSchema(
   'BaseLinearDisplay',
   {
-    mouseover: {
-      type: 'string',
-      description: 'what to display in a given mouseover',
-      defaultValue: `function(feature) {
-  return feature.get('name')
-}`,
-      functionSignature: ['feature'],
-    },
     maxDisplayedBpPerPx: {
       type: 'number',
       description: 'maximum bpPerPx that is displayed in the view',
diff --git a/plugins/linear-genome-view/src/LinearBasicDisplay/configSchema.ts b/plugins/linear-genome-view/src/LinearBasicDisplay/configSchema.ts
index e791c2a5ce..ad0d4f1f1a 100644
--- a/plugins/linear-genome-view/src/LinearBasicDisplay/configSchema.ts
+++ b/plugins/linear-genome-view/src/LinearBasicDisplay/configSchema.ts
@@ -5,7 +5,17 @@ import { baseLinearDisplayConfigSchema } from '../BaseLinearDisplay'
 export function configSchemaFactory(pluginManager: PluginManager) {
   return ConfigurationSchema(
     'LinearBasicDisplay',
-    { renderer: pluginManager.pluggableConfigSchemaType('renderer') },
+    {
+      mouseover: {
+        type: 'string',
+        description: 'what to display in a given mouseover',
+        defaultValue: `function(feature) {
+  return feature.get('name')
+}`,
+        functionSignature: ['feature'],
+      },
+      renderer: pluginManager.pluggableConfigSchemaType('renderer'),
+    },
     {
       baseConfiguration: baseLinearDisplayConfigSchema,
       explicitlyTyped: true,