Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Alignments track read grouping #912

Closed
rbuels opened this issue May 5, 2020 · 8 comments · Fixed by #4519
Closed

add Alignments track read grouping #912

rbuels opened this issue May 5, 2020 · 8 comments · Fixed by #4519
Labels

Comments

@rbuels
Copy link
Contributor

rbuels commented May 5, 2020

Group reads by:

  • read strand
  • first-of-pair strand
  • sample
  • library
  • read group
  • chromosome of mate
  • pair orientation
  • supplementary flag
  • read order
  • tag
  • base at XXXX (centerline position)
@rbuels rbuels added the enhancement New feature or request label May 5, 2020
@rbuels
Copy link
Contributor Author

rbuels commented May 5, 2020

implementation sketch:

  • make a new layout class called GroupedLayout that manages a set of GranularRectLayouts, one per grouping
  • make the PileupRenderer use this layout for certain render props

@cmdcolin
Copy link
Collaborator

cmdcolin commented Jan 5, 2021

just gotta give a +1 to this one, i think it would be really good and it often really clarifies the data to view it in read groups

exciting screenshots like https://pbs.twimg.com/media/Eq66gYtUYAAzZAy?format=png&name=4096x4096 show grouping by haplotype HP tag is quite nice.

@cmdcolin
Copy link
Collaborator

cmdcolin commented Jan 5, 2021

note that we can sort of make a hackey approach to group by for example if we (a) copy track and (b) filter by tag in the copied track (once #1473 is added)

@rbuels
Copy link
Contributor Author

rbuels commented Jun 14, 2021

@cmdcolin just noticed this issue was marked "In Progress", what's its status?

@cmdcolin
Copy link
Collaborator

It is perhaps stalled? I dunno. I'm not actively working on it but would be cool to see it make progress somehow. We could introduce an extra category on the board if it helps

@cmdcolin
Copy link
Collaborator

See #1942 for working demo of this though

@cmdcolin
Copy link
Collaborator

my current thinking on this is to make e.g. spawn multiple alignments tracks. this is the easiest implementation wise, is the most general. it may have a bit less usability but it will create e.g. a separate SNPCoverage track for each group which i think can be valuable (igv does not do this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants