Ctrl+z inside textfield does (unexpected?) top-level undo on the state tree

[cmdcolin]

I opened a new linear genome view and was typing in a refnameautocomplete, a input textfield, and hit ctrl+z intending it to undo some text i typed, but instead it removed the whole linear genome view, because that was the last state tree action. It may be worth thinking about whether this ctrl+z behavior here is too strong, and maybe should only activate under more limited circumstances

[cmdcolin]

possible discussion of similar issue in another project WordPress/gutenberg#18755

[rbuels]

Sounds like the ctrl-z should just have been captured by the text field.

…

On Fri, Apr 14, 2023 at 9:10 AM Colin Diesh ***@***.***> wrote: possible discussion of similar issue in another project WordPress/gutenberg#18755 <WordPress/gutenberg#18755> — Reply to this email directly, view it on GitHub <#3638 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASAFKKDTSDQWJGSRV2IVDXBFZFPANCNFSM6AAAAAAW3FOJEQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[cmdcolin]

i'm not sure if there another way but "capturing" would seem to mean stopPropagation on all undo/redo type key strokes(?) on all text fields, and thus puts the "onus" of doing that on all text fields, which seems a bit odd

[rbuels]

But looking at it another way: what should happen when hitting ctrl-z in a text field? I think the text field should do an undo. Maybe there is a non-repetitive way to make all our text fields capture ctrl-z.

[rbuels]

But also, you're right, having ctrl-z undo a whole view action might be a bit much, a user could be surprised that it happened. Maybe have a confirmation dialog? Or maybe ctrl-z wouldn't do top-level undoing?

[cmdcolin]

one possible thing for this would be to not use ctrl+z for our undo, but rather some other keycode that doesn't overlap with the browser