Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate tooltip on LGV scalebar in some cases #1556

Closed
cmdcolin opened this issue Dec 13, 2020 · 4 comments
Closed

Inaccurate tooltip on LGV scalebar in some cases #1556

cmdcolin opened this issue Dec 13, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@cmdcolin
Copy link
Collaborator

localhost_3000__config=test_data%2Fconfig_demo json session=local-vjOKhSu6k (1)
localhost_3000__config=test_data%2Fconfig_demo json session=local-vjOKhSu6k

Seen while testing #1531 and showing all regions in an assembly

@cmdcolin cmdcolin added the bug Something isn't working label Dec 13, 2020
@cmdcolin
Copy link
Collaborator Author

Screenshots show normal scalebar and overview scale bar both see this issue

@rbuels
Copy link
Contributor

rbuels commented Dec 15, 2020

is this related to #1532? (noticed by @cmdcolin )

@cmdcolin
Copy link
Collaborator Author

I pushed a proposed change for the LGV scalebar tooltip (and not the overviewscalebar tooltip yet) here 535800b

It is easier to simply use this branch because you can show all regions in assembly using the toggle switch on it

After this change, the pxToBp logic is beginning to look a bit stringy, and it even still does not properly take care of ellided blocks

@cmdcolin cmdcolin self-assigned this Dec 22, 2020
@cmdcolin
Copy link
Collaborator Author

This issue is kinda stumping me

Here is a share link on master demonstrating the issue...try using the tooltip between Y and X

http://s3.amazonaws.com/jbrowse.org/code/jb2/master/index.html?config=test_data%2Fconfig_demo.json&session=share-Jj9_f218L3&password=DJ7DO

Can see from this screenshot that X is showing in a tooltip in the Y zone, and also the X reflabel is badly positioned but that is a separate issue

s3 amazonaws com_jbrowse org_code_jb2_master_index html_config=test_data%2Fconfig_demo json session=local-1vi36AZ5i

I don't really have any good insights...i've just been poking with things, trying to incorporate or not incorporate interRegionPaddingBlockPx widths into the pxToBp (e.g. it should say possibly that (region.end-region.start)/bpPerPx > minimumBlockWidth then add interRegionPaddingBlockPx) and sometimes it works and sometimes it doesn't ....would be curious if anyone has any ideas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants