From 25429596454fa982a6865cade705a163a037b925 Mon Sep 17 00:00:00 2001
From: Colin <colin.diesh@gmail.com>
Date: Thu, 18 Feb 2021 22:15:53 -0700
Subject: [PATCH] Remove notion from typescript in assemblyManager that
 assemblyManager.addAssembly can take a snapshot

---
 .../core/assemblyManager/assemblyManager.ts     | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/packages/core/assemblyManager/assemblyManager.ts b/packages/core/assemblyManager/assemblyManager.ts
index 567d981422..acccb14f8e 100644
--- a/packages/core/assemblyManager/assemblyManager.ts
+++ b/packages/core/assemblyManager/assemblyManager.ts
@@ -4,9 +4,8 @@ import {
   cast,
   getParent,
   IAnyType,
-  SnapshotOrInstance,
-  types,
   Instance,
+  types,
 } from 'mobx-state-tree'
 import { when } from '../util'
 import { readConfObject } from '../configuration'
@@ -151,19 +150,19 @@ export default function assemblyManagerFactory(
           ),
         )
       },
+
+      // this can take an active instance of an assembly, in which case it is
+      // referred to, or it can take an identifier e.g. assembly name, which is
+      // used as a reference. snapshots cannot be used
       addAssembly(
-        assemblyConfig: SnapshotOrInstance<typeof assemblyConfigType> | string,
+        assemblyConfig: Instance<typeof assemblyConfigType> | string,
       ) {
         self.assemblies.push({ configuration: assemblyConfig })
       },
-      // addAssemblyConf(
-      //         assemblyConfig: SnapshotOrInstance<typeof assemblyConfigType> | string,
-      //       ) {
-      //         self.assemblies.push({ configuration: assemblyConfig })
-      //       }
+
       replaceAssembly(
         idx: number,
-        assemblyConfig: SnapshotOrInstance<typeof assemblyConfigType> | string,
+        assemblyConfig: Instance<typeof assemblyConfigType> | string,
       ) {
         self.assemblies[idx] = cast({
           configuration: assemblyConfig,