Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external flag for broker makes non-ZeroMQ cores not work #634

Closed
nightlark opened this issue Feb 26, 2019 · 7 comments
Closed

external flag for broker makes non-ZeroMQ cores not work #634

nightlark opened this issue Feb 26, 2019 · 7 comments
Labels
bug Issue concerning incorrect code operation
Milestone

Comments

@nightlark
Copy link
Member

Describe the bug
Starting the broker with --external with a core type other than ZeroMQ causes the broker to not work (federates are unable to connect).

What is the expected behavior?
The other core types should continue working when given --external (they don't seem to need it, so it should either be ignored or it should be removed from the help message of non-ZMQ cores and give an error/warning when used).

Environment (please complete the following information):

@nightlark nightlark added the bug Issue concerning incorrect code operation label Feb 26, 2019
@nightlark
Copy link
Member Author

This also applies when using --ipv4 (and I imagine --ipv6 as well).

@phlptp phlptp added this to the HELICS 2.1 milestone Jun 1, 2019
@phlptp
Copy link
Member

phlptp commented Jun 18, 2019

Have you tried this with the UDP broker?

@nightlark
Copy link
Member Author

I don't remember. The TCP core definitely wasn't working.

@phlptp
Copy link
Member

phlptp commented Jun 18, 2019

I was able to verify the TCP issue as well, but the UDP core works differently so I wasn't sure if that fails in this context as well. I will test it soon, but I wondered if you knew.

@phlptp
Copy link
Member

phlptp commented Jun 23, 2019

Ok, @nightlark can you check again.

@nightlark
Copy link
Member Author

I tested the tcp, tcpss, and udp cores; the --external flag no longer breaks any of them.

@phlptp
Copy link
Member

phlptp commented Jun 25, 2019

closed with PR #720

@phlptp phlptp closed this as completed Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue concerning incorrect code operation
Projects
None yet
Development

No branches or pull requests

2 participants