Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve splitter #272

Merged
merged 5 commits into from
Dec 2, 2020
Merged

Improve splitter #272

merged 5 commits into from
Dec 2, 2020

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Oct 29, 2020

Makes use of LazyEvaluatedObjects and PreparedGeometrys to improve performance of geometry splitter (used in aggreateByGeometry queries):

  • use PreparedGeometry.intersects to reduce expensive intersection calls
    • todo: can this optimization be applied in the "regular" cell-iterator also?
  • use LazyEvaluatedObject to avoid expensive calculations of intersections when they might not get used after all.

Checklist

@tyrasd tyrasd added the performance Performance optimizations, bottlenecks of the current pipeline, etc. label Oct 29, 2020
@tyrasd tyrasd self-assigned this Oct 29, 2020
@tyrasd tyrasd changed the title 🚧 Improve splitter Improve splitter Nov 18, 2020
@tyrasd tyrasd added the waiting for review This pull request needs a code review label Nov 18, 2020
Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: can this optimization be applied in the "regular" cell-iterator also?

What happens with this todo? Is there already an issue for that, if necessary?

@joker234 joker234 removed the waiting for review This pull request needs a code review label Dec 2, 2020
@tyrasd
Copy link
Member Author

tyrasd commented Dec 2, 2020

todo: can this optimization be applied in the "regular" cell-iterator also?

What happens with this todo? Is there already an issue for that, if necessary?

-> #289

@tyrasd tyrasd merged commit 55a8f45 into master Dec 2, 2020
@tyrasd tyrasd deleted the improve-splitter branch December 2, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance optimizations, bottlenecks of the current pipeline, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants