Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'groupByObject" to 'groupByObjectId' in JSON response #84

Open
bonaparten opened this issue Nov 18, 2020 · 4 comments
Open

Change 'groupByObject" to 'groupByObjectId' in JSON response #84

bonaparten opened this issue Nov 18, 2020 · 4 comments
Labels
brainstorming Idea for a potential new feature or adaption that still needs further discussion
Milestone

Comments

@bonaparten
Copy link
Contributor

The value of groupByObject in a JSON response represents the ID of the object, not the object itself.
groupByObject should be changed to groupByObjectId or something similar.

@bonaparten bonaparten added the code quality Topics around code quality, e.g. refactoring, better naming of methods/classes label Nov 18, 2020
@bonaparten bonaparten added this to the 1.3 milestone Nov 18, 2020
@FabiKo117
Copy link
Contributor

@tyrasd
Copy link
Member

tyrasd commented Nov 18, 2020

see also 360508a, #57 (comment) and #80

@tyrasd tyrasd added the brainstorming Idea for a potential new feature or adaption that still needs further discussion label Nov 18, 2020
@tyrasd tyrasd modified the milestones: 1.3, 2.0 Nov 18, 2020
@tyrasd
Copy link
Member

tyrasd commented Nov 18, 2020

what would you do with the multi-groupBy requests, like /groupBy/boundary/groupBy/tag/ for example. currently, those look like this:

    "groupByObject" : [ "Heidelberg", "highway=tertiary" ]

Would you name those groupByObjectIds or groupByObjectsIds perhaps?

@tyrasd tyrasd removed the code quality Topics around code quality, e.g. refactoring, better naming of methods/classes label Nov 18, 2020
@FabiKo117
Copy link
Contributor

We've decided in a 2.0 release meeting that we want to call this response object simply group for all the /groupBy responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brainstorming Idea for a potential new feature or adaption that still needs further discussion
Projects
None yet
Development

No branches or pull requests

3 participants