Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hazard data window - layer name #822

Open
stufraser1 opened this issue Dec 15, 2017 · 7 comments
Open

Update hazard data window - layer name #822

stufraser1 opened this issue Dec 15, 2017 · 7 comments
Assignees

Comments

@stufraser1
Copy link
Member

stufraser1 commented Dec 15, 2017

Where hazard set name is shown, use layer title instead.
@ErikKBethke testing potential name lengths

Camptocamp:
On basis of above, to advise possible solutions to displaythe lengths we have
Where descriptor is 'hazard set' on screen, use 'Displayed data'

@fjacon
Copy link
Collaborator

fjacon commented Jan 29, 2018

@stufraser1 could you give us an example or two ? Thanks

@stufraser1
Copy link
Member Author

@ErikKBethke Have you made progress on updating the layer title to be more user-reable?
We need to assign some in GeoNode, to provide final examples to camptocamp.

@fjacon fjacon assigned ErikKBethke and unassigned tonio Feb 1, 2018
@ErikKBethke
Copy link

I have been holding off on actually updating the layer titles in GeoNode, but can start pushing some examples to the production server (a great example would be the GEM layers to test with).

If you would like me to update what I have, please advise. There are quite a few layers and I am still working through the naming convention for most.

Having looked into this a bit, I believe we would run into issues with the new naming convention being used in the legend due to two issues: the layer name is quite lengthy and would likely need to be abbreviated, and using layer title instead of hazard set would not necessarily make sense (given the return periods being in layer title which is not how the legend operates). It might make sense to also update hazard set titles and continue to use those.

@ErikKBethke
Copy link

ErikKBethke commented Feb 16, 2018

Regarding the changes to be made, I would think that once the changes go live it would be fairly simple to update the legend by modifying the way that the report_hazard_category.jinja2 is set up. Could be as simple as modifying the following code (lines 154-155) to deal with lengthy params:

<dt>Hazard set</dt> <dd>{{hazardset.id}}</dd>

@fjacon
Copy link
Collaborator

fjacon commented Feb 27, 2018

@stufraser1 : I agree with @ErikKBethke that using layer title instead of hazard set would not necessarily make sense.

@stufraser1
Copy link
Member Author

@fjacon I understand the hesitation to use layer title because of the return period value being in layer title. Internally we had discussed to update hazard set to be the same as layer title, without the return period value as Erik noted ("It might make sense to also update hazard set titles and continue to use those").
= It is agreed to keep using hazard set.

The issue remains that hazard set string would become longer as they comprise the country/region and peril spelled out in full

Examples have already been included at https://www.geonode-gfdrrlab.org/search/?title__icontains=Cyclone&limit=100&offset=0
The hazard sets (not yet updated) for the layers on this link would be
Cyclone FSM+Guam KIT (from CY_FSMGUAM_KIT)
Cyclone Vietnam KIT (from CY_VN_KIT)
Cyclone Philippines KIT (from CY_PH_KIT)

Another example https://www.geonode-gfdrrlab.org/layers/hazard:ts_mih_rp500:
hazard set 'GTM Global Tsunami Hazard'
layer titles 'Global Tsunami Hazard GTM RP500' etc

@stufraser1 stufraser1 assigned stufraser1 and unassigned ErikKBethke Mar 29, 2018
@stufraser1
Copy link
Member Author

need to provide table of current name / layer ID to new name, for new SQL query to perform conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants