Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema] should taxonomy be optional in vulnerability? #202

Closed
odscjen opened this issue Aug 22, 2023 · 6 comments · Fixed by #218
Closed

[Schema] should taxonomy be optional in vulnerability? #202

odscjen opened this issue Aug 22, 2023 · 6 comments · Fixed by #218
Labels
vulnerability Issues related to Vulnerability data

Comments

@odscjen
Copy link
Contributor

odscjen commented Aug 22, 2023

From example being developed in #135 (comment) the dataset doesn't have a specific taxonomy scheme that it's used. Should we make this field optional instead of required?

If it does need to stay as required we should add a code to 'classification_schema.csv' to cover these scenario's for consistency and add a bit to the guidance to state what to use in this situation.

Code Title Definition Source Category
internal Internal The categories defined within the dataset methodology. These have not been explicitly taken from a declared taxonomy scheme.
@odscjen odscjen changed the title [Schema] should taxonomy be option in vulnerability? [Schema] should taxonomy be optional in vulnerability? Aug 22, 2023
@odscjen odscjen added the vulnerability Issues related to Vulnerability data label Aug 22, 2023
@stufraser1
Copy link
Member

Good point - some vulnerability relationships relate to only a general occupancy type e.g. 'residential', 'commercial', 'industrial'.

Either we (1) assign taxonomy type based on this - we can create one in ODS/GEM taxonomies for general residential with all other taxonomy string components as unknown, or (2) make taxonomy optional and fall back on the occupancy type only - which now I look for it, isn't within the schema or codelists (was this removed, we had it in at one point).

We need some way to tie the V relationships to a type of exposure - and using exposure_ctegory to tie it to 'buildings' is not enough.

@odscjen
Copy link
Contributor Author

odscjen commented Aug 22, 2023

We did remove occupancy type as this isn't necessarily always the same across every asset in a dataset.

vulnerability.taxonomy as it stands doesn't hold the actual taxonomy codes (for the same reason of them not being the same across every asset in a dataset), it gives the name of the scheme that the taxonomy codes in the dataset are taken from, e.g. GED4ALL.

@matamadio
Copy link
Contributor

Taxonomy should be optional, because exposure grouping is often custom.

some vulnerability relationships relate to only a general occupancy type e.g. 'residential', 'commercial', 'industrial'.

That is true, yet datasets could include one or more of these occupancy types. Right now we identify only category (buildings, infrastructure, agriculture, population, natural environment). Occupancy type would refer only to buildings.
I would keep occupancy details as part of data instead of metadata - at least for this release.

@stufraser1
Copy link
Member

Not having this in the metadata reduces search capability - it is useful for users searching V functions to filter by those suitable for Residential buildings, or by a certain construction type, for example (see OpenQuake tool example), but yes by including in metadata we potentially introduce long string / array of occupancy types

@odscjen
Copy link
Contributor Author

odscjen commented Aug 24, 2023

For this iteration of the standard I think we should make it optional. The next version of the standard could look to work out if occupancy is worth putting back in, and in conjunction making taxonomy (the name of the taxonomy scheme) required. @matamadio @stufraser1 is this okay?

@odscjen
Copy link
Contributor Author

odscjen commented Aug 28, 2023

@stufraser1 are you okay with the above suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vulnerability Issues related to Vulnerability data
Projects
Development

Successfully merging a pull request may close this issue.

3 participants