Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Balance responses should extend BaseUserResponse #334

Closed
Yoronex opened this issue Sep 26, 2024 · 1 comment · Fixed by #345
Closed

[Feature] Balance responses should extend BaseUserResponse #334

Yoronex opened this issue Sep 26, 2024 · 1 comment · Fixed by #345
Assignees
@Yoronex
Labels
Priority: Medium Type: Enhancement

Comments

@Yoronex
Copy link
Member

Yoronex commented Sep 26, 2024

What would you like?

The BalanceResponse should extend the BaseUserResponse.

Why is this needed?

If we include such information, it is much easier to see to which user a fetched balance actually belongs. This is especially relevant around handing out fines, so the frontend can easily show each user's balance and total fine.

How could it be implemented?

No response

Other information

No response
This was referenced Oct 6, 2024
Merged
Merged
@Yoronex Yoronex linked a pull request Oct 6, 2024 that will close this issue
feat: extend balance response with extra user attributes #345
Merged
@Yoronex
Copy link
Member Author

Yoronex commented Oct 8, 2024

These issues can probably implemented in the same PR:
#346
#352

@Yoronex Yoronex mentioned this issue Oct 8, 2024
Open
@Yoronex Yoronex self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yoronex Yoronex

Labels
Priority: Medium Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: extend balance response with extra user attributes GEWIS/sudosos-backend
1 participant
@Yoronex