[Bug] While loop and function create bad generation (dace:cpu)

[FlorianDeconinck]

Porting UW showed than in dace:cpu, when a gtscript.function is called within a while the system allows itself to optimize code outside of the while loop, breaking control flow.

Use case from UW.

This works for tracer 15, slope is a gtscript.function:

 temp[0,0,0] = tr0[0,0,0][15]
 temp_above[0,0,0] = tr0[0,0,1][15]
 temp_below[0,0,0] = tr0[0,0,-1][15]
 sstr0[0,0,0][15] = slope(kmask,temp,temp_above,temp_below,pmid0,pmid0_above,pmid0_below)

When written properly in a while loop, generated code is broken (sstr0 is set outside of the loop!)

n=0
while n < constants.ncnst:
  temp[0,0,0] = tr0[0,0,0][n]
  temp_above[0,0,0] = tr0[0,0,1][n]
  temp_below[0,0,0] = tr0[0,0,-1][n]
  sstr0[0,0,0][n] = slope(kmask,temp,temp_above,temp_below,pmid0,pmid0_above,pmid0_below)
  n+=1

[FlorianDeconinck]

This is due to fauly CallInliner missing the While loop visitor to inline the statements of the function call. PR upcoming.

[FlorianDeconinck]

PR on gt4py: GridTools/gt4py#1669