Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uwshcu.F90 has a regression bug #874

Open
atrayano opened this issue Dec 22, 2023 · 0 comments
Open

uwshcu.F90 has a regression bug #874

atrayano opened this issue Dec 22, 2023 · 0 comments
Assignees

Comments

@atrayano
Copy link
Contributor

The limiter uses a scheme involving cnvtr. But the pointer to this variable is passed in from an export of Moist (CNPCPRATE).

The regression (start/stop and 0 IAU increments) fails, unless tests are using either LM=72, or BACM_1M, or UW_OPTIONS: NONE

Inside GEOS_UW_Interface.F90 there is logic that if (LM==72) the default for JASON_UW is set to true (false otherwise). And with JASON_UW on, one of the parameters we set there effectively chooses a different limiter. Of course, the regression passes when we choose BACM_1M since we are not using UW shallow water code,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants