Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handleInc_ procedure is not being trapped on error #812

Open
bena-nasa opened this issue Aug 30, 2023 · 0 comments
Open

handleInc_ procedure is not being trapped on error #812

bena-nasa opened this issue Aug 30, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@bena-nasa
Copy link
Collaborator

While chasing a replay issue for a user, I was running an ERA5 replay and forgot to add

REPLAY_O3: NO

as did the user. The ERA5 files do not have an O3 analysis. This causes the handleInc_ procedure to throw an error.
The particular code is this:

        if( .not.FOUND .and. L_REPLAY_O3 ) then
           write(STRING,'(A)') "ANA Variable: O3 Not Found!"
           call WRITE_PARALLEL( trim(STRING)   )
           RETURN_(ESMF_FAILURE)
        endif

but if one looks when handleInc_ is called the return code is not checked, making any sort of error handling like this pointless. The error code should be check so the code dies if the user is trying to replay a variable that does not exist in the file. By returning early from handleInc_ clearly a lot of code in handleInc_ is skipped but we run along.

@bena-nasa bena-nasa added the bug Something isn't working label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants