Feature/wdboggs/use acg #6
Conversation
…e CMakeLists.txt for ACG
… calls for fields with CHILD_ID option
|
Will this be automatically tested for zero diff in coupled mode, or do we still need to run a zero diff test manually? |
|
fixes #6 |
|
There are multiple errors when building, please see ⬇️ @tclune I will be in touch to get help. @darianboggs, you can ignore this message or if you know how to fix, please commit. Thanks!
|
|
I think the problem is related to certain fields being both Import and Export. ACG generates pointer declarations for ALL the GridSpec's. So that means that it generates declarations for some fields twice. I restored the pointer declarations and MAPL_GetPointer calls and removed the I committed changes, and I am compiling now. I'll let you know how it turns out. |
|
That's true! We have some silly stuff going on. I can take care of it by renaming the variables and dealing with the exports. It's up to you to leave it there for me. Thanks for the help! |
|
Great! It compiled successfully. ACG has a narrow focus currently. So doesn't handle a case like yours fully, though it might be a valid case. Nonetheless, you do get the benefit of it generating most of the So, you may not need or want to change the variables. ACG generates pointer declarations and |
|
We definitely need @atrayano to comment on the deeper issue here when he's back online. |
|
@darianboggs, Thanks for the modifications. It builds for me too. Thanks again! |
|
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement |
sanAkel
added
the
0 diff structural
…o FRACICE for ACG to work. You can check auto-generated code at: src/Components/@GEOSgcm_GridComp/GEOSogcm_GridComp/@GEOS_OceanGridComp/GEOSdatasea_GridComp/
…. No change in answers.
…e the variable names DO NOT have quotes.
…OM6_GEOSPlug_DeclarePointer___.h and MOM6_GEOSPlug_GetPointer___.h are NOT being used right now, because a few variables are dummy imports (e.g., SWHEAT) and exports (e.g, DH, T, S) from MOM6 ocean model. Unless these dummy imports and exports disappear and connectivity is CLEANED up, using these ACG files is almost impossible.Someday when MOM5 is deprecated, revisit.
… marked as DUMMY_EXPORT, they are there only because of messy connectivities.
… messy connectivities.
…ices, can not use Declare and Get Pointers because same names are used (twice) to import and export- ACG creates statements twice, so it cannot used unless these imports and exports are RENAMED. If they are renamed- NOW, all connectivity gets messed up- so do it another day
|
ACG is now implemented across the board in: Answers are preserved in:
Significant amount of tidying up has been done as well. |
There was a problem hiding this comment.
@darianboggs, @mathomp4, This is good to go now. If you feel like, please take a look. All tests passed. ✅
@mathomp4, You probably need to use super powers to merge it! 😄
|
If you're happy, I'm happy. I'll merge in now. I suppose you should soon make a PR to GEOSgcm so we can get the CI working again in here... |
Began implementation of ACG in GEOS_OceanGridComp