Sync main with develop #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e CMakeLists.txt for ACG
… calls for fields with CHILD_ID option
… & GetPointer calls
…pr1586 Update MOM6: routine maintenance-2022-11-10
Due to changes at Heroku, we need to transition to use a GitHub Action for label enforcement. The current label enforcer no longer works, so PRs will be "stuck" until this is fixed.
…forcer-ocean Move to use GitHub Action for Label Enforcement
…o FRACICE for ACG to work. You can check auto-generated code at: src/Components/@GEOSgcm_GridComp/GEOSogcm_GridComp/@GEOS_OceanGridComp/GEOSdatasea_GridComp/
…. No change in answers.
…e the variable names DO NOT have quotes.
…OM6_GEOSPlug_DeclarePointer___.h and MOM6_GEOSPlug_GetPointer___.h are NOT being used right now, because a few variables are dummy imports (e.g., SWHEAT) and exports (e.g, DH, T, S) from MOM6 ocean model. Unless these dummy imports and exports disappear and connectivity is CLEANED up, using these ACG files is almost impossible.Someday when MOM5 is deprecated, revisit.
… marked as DUMMY_EXPORT, they are there only because of messy connectivities.
… messy connectivities.
…ices, can not use Declare and Get Pointers because same names are used (twice) to import and export- ACG creates statements twice, so it cannot used unless these imports and exports are RENAMED. If they are renamed- NOW, all connectivity gets messed up- so do it another day
Feature/wdboggs/use acg
sanAkel
added
the
0 diff
mathomp4
previously approved these changes
Dec 22, 2022
mathomp4
added
the
Contingent - DNA
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA |
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA |
mathomp4
removed
the
Contingent - DNA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simple does what the
titlestates!