From 79034c5c974b89adc09aa185733062e9f5c6f96b Mon Sep 17 00:00:00 2001
From: Tomasz <twoln@umk.pl>
Date: Thu, 4 Apr 2024 09:35:55 +0000
Subject: [PATCH] removing a forgotten print_r and attempting to make
 Scrutinizier happier about supposed security problem - which is a false
 positive

---
 web/admin/overview_federation.php | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/web/admin/overview_federation.php b/web/admin/overview_federation.php
index 9a2409ee6..84ea21bfe 100644
--- a/web/admin/overview_federation.php
+++ b/web/admin/overview_federation.php
@@ -98,14 +98,16 @@
 
     <?php
     $mgmt = new \core\UserManagement();
-print_r($certStatusIcons[0]);
+    $fed_id = '';
     if ($user->isSuperadmin() && isset($_GET['fed_id'])) {
         $cat = new \core\CAT(); // initialises Entity static members
         $fedIdentifiers = array_keys($cat->knownFederations);
         if (!in_array(strtoupper($_GET['fed_id']), $fedIdentifiers)) {
             throw new Exception($this->inputValidationError(sprintf("This %s does not exist!", \core\common\Entity::$nomenclature_fed)));
+        } else {
+            $fed_id = $_GET['fed_id'];
         }
-        $feds = [['name'=>' user:fedadmin', 'value' => $_GET['fed_id']]];
+        $feds = [['name'=>' user:fedadmin', 'value' => $fed_id]];
     } elseif (!$user->isFederationAdmin()) {
         echo "<p>" . sprintf(_("You are not a %s manager."), $uiElements->nomenclatureFed) . "</p>";
         echo $deco->footer();