Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCKs exported from 4.4-dev5 and newer aren't read correctly #236

Closed
Winonamac opened this issue Dec 26, 2024 · 4 comments · Fixed by #238
Closed

PCKs exported from 4.4-dev5 and newer aren't read correctly #236

Winonamac opened this issue Dec 26, 2024 · 4 comments · Fixed by #238
Labels
bug Something isn't working

Comments

@Winonamac
Copy link

System information

Windows 11

Issue description

Somewhere between Godot 4.4-dev4 and Godot 4.4-dev5 some change was made to the PCK format that made GDRE unable to extract files from it properly.

Steps to reproduce

  1. Create or open a project in Godot 4.4-dev5
  2. Export said project
  3. Attempt to recover it using Godot RE Tools, v0.8.0

Recovery log

GDRE Tools v0.8.0
Windows 10.0.22631, NVIDIA GeForce RTX 3060, opengl3
At least one error was detected while extracting pack!
.godot/exported/133200997/export-3070c538c03ee49b7677ff960a3f5195-main.scn(12)
.godot/global_script_class_cache.cfg(12)
.godot/imported/icon.svg-218a8f2b3041327d8a5756f3a245f83b.ctex(12)
.godot/uid_cache.bin(12)
icon.svg(12)
icon.svg.import(12)
main.tscn.remap(12)
project.binary(12)
secret.txt(12)

WARNING: Converting lossy imports, you may lose fidelity for indicated assets when re-importing upon loading the project
   at: ImportExporter::_export_imports (modules\gdsdecomp\utility\import_exporter.cpp:181)
WARNING: No import files found!
   at: ImportExporter::_export_imports (modules\gdsdecomp\utility\import_exporter.cpp:186)

Link to game download

test-project.zip

@Winonamac Winonamac added the bug Something isn't working label Dec 26, 2024
@nikitalita
Copy link
Collaborator

I need the actual pck to test it.

@Winonamac
Copy link
Author

My apologies. I forgot to include it in the zip.

Exported from 4.4-dev7
test.zip

@nikitalita
Copy link
Collaborator

I found the issue. They started trimming the res:// prefix from the paths in PCK files. When the build job is done, try the standalone artifacts here: https://github.com/GDRETools/gdsdecomp/actions/runs/12530048823?pr=238

@Winonamac
Copy link
Author

That seems to have been it. Everything is able to be recovered properly from the pck now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants