Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building from source fails with latest version of Godot #229

Closed
psonthomphanech opened this issue Dec 7, 2024 · 1 comment · Fixed by #232
Closed

Building from source fails with latest version of Godot #229

psonthomphanech opened this issue Dec 7, 2024 · 1 comment · Fixed by #232
Labels
bug Something isn't working

Comments

@psonthomphanech
Copy link

psonthomphanech commented Dec 7, 2024

System information

Windows

Issue description

Building fails with the following error

[ 22%] Compiling modules\gdsdecomp\exporters\sample_exporter.cpp ...
[ 22%] C:\...\godot\modules\gdsdecomp\compat\file_access_encrypted_v3.h(86): error C2555: 'FileAccessEncryptedv3::store_8': overriding virtual function return type differs and is not covariant from 'FileAccess::store_8'
.\core/io/file_access.h(201): note: see declaration of 'FileAccess::store_8'
C:\...\godot\modules\gdsdecomp\compat\file_access_encrypted_v3.h(87): error C2555: 'FileAccessEncryptedv3::store_buffer': overriding virtual function return type differs and is not covariant from 'FileAccess::store_buffer'
.\core/io/file_access.h(218): note: see declaration of 'FileAccess::store_buffer'
modules\gdsdecomp\compat\file_access_encrypted_v3.cpp(100): warning C4458: declaration of 'key' hides class member
C:\...\godot\modules\gdsdecomp\compat\file_access_encrypted_v3.h(50): note: see declaration of 'FileAccessEncryptedv3::key'
[ 22%] Compiling modules\gdsdecomp\exporters\scene_exporter.cpp ...
scons: *** [modules\gdsdecomp\compat\file_access_encrypted_v3.windows.editor.x86_64.obj] Error 2
modules\gdsdecomp\compat/file_access_encrypted_v3.h(86): error C2555: 'FileAccessEncryptedv3::store_8': overriding virtual function return type differs and is not covariant from 'FileAccess::store_8'
.\core/io/file_access.h(201): note: see declaration of 'FileAccess::store_8'
modules\gdsdecomp\compat/file_access_encrypted_v3.h(87): error C2555: 'FileAccessEncryptedv3::store_buffer': overriding virtual function return type differs and is not covariant from 'FileAccess::store_buffer'
.\core/io/file_access.h(218): note: see declaration of 'FileAccess::store_buffer'
.\core/typedefs.h(122): warning C4018: '>': signed/unsigned mismatch
.\core/typedefs.h(122): note: the template instantiation context (the oldest one first) is
modules\gdsdecomp\bytecode\bytecode_base.cpp(588): note: see reference to function template instantiation 'auto MAX<int,V>(const T,const T2)' being compiled
        with
        [
            V=uint32_t,
            T=int,
            T2=uint32_t
        ]
modules\gdsdecomp\bytecode\bytecode_base.cpp(760): warning C4018: '>=': signed/unsigned mismatch
scons: *** [modules\gdsdecomp\bytecode\bytecode_base.windows.editor.x86_64.obj] Error 2
modules\gdsdecomp\exporters\oggstr_exporter.cpp(73): warning C4018: '>': signed/unsigned mismatch
C:\...\godot\modules\gdsdecomp\utility/file_access_gdre.h(117): error C2555: 'FileAccessGDRE::store_8': overriding virtual function return type differs and is not covariant from 'FileAccess::store_8'
.\core/io/file_access.h(201): note: see declaration of 'FileAccess::store_8'
C:\...\godot\modules\gdsdecomp\utility/file_access_gdre.h(118): error C2555: 'FileAccessGDRE::store_buffer': overriding virtual function return type differs and is not covariant from 'FileAccess::store_buffer'
.\core/io/file_access.h(218): note: see declaration of 'FileAccess::store_buffer'
scons: *** [modules\gdsdecomp\register_types.windows.editor.x86_64.obj] Error 2
modules\gdsdecomp\compat/file_access_encrypted_v3.h(86): error C2555: 'FileAccessEncryptedv3::store_8': overriding virtual function return type differs and is not covariant from 'FileAccess::store_8'
.\core/io/file_access.h(201): note: see declaration of 'FileAccess::store_8'
modules\gdsdecomp\compat/file_access_encrypted_v3.h(87): error C2555: 'FileAccessEncryptedv3::store_buffer': overriding virtual function return type differs and is not covariant from 'FileAccess::store_buffer'
.\core/io/file_access.h(218): note: see declaration of 'FileAccess::store_buffer'
scons: *** [modules\gdsdecomp\editor\gdre_editor.windows.editor.x86_64.obj] Error 2
scons: building terminated because of errors.

I'm able to build successfully on an earlier version of the source from just before v0.8.0: godotengine/godot@b31cc69

Steps to reproduce

Building with scons platform=windows
Using the latest Godot 4.4 source on master and the Visual Studio compiler

Recovery log

n/a

Link to game download

n/a

@psonthomphanech psonthomphanech added the bug Something isn't working label Dec 7, 2024
@nikitalita
Copy link
Collaborator

Looks like they broke the API yet again. I'll fix it soon; in the meantime, use godotengine/godot@ec6a1c0 , that's what we're using on the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants