Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storm helm chart and external zookeeper #60

Open
alessio1983lx opened this issue Dec 16, 2021 · 2 comments · May be fixed by #118
Open

storm helm chart and external zookeeper #60

alessio1983lx opened this issue Dec 16, 2021 · 2 comments · May be fixed by #118

Comments

@alessio1983lx
Copy link

alessio1983lx commented Dec 16, 2021

Hello,

I cannot figure out how to deploy the storm cluster with an external zookeeper…

Trying something like this:

helm install storm gresearch/storm
--set zookeeper.enabled=false
--set zookeeper.servers[0]=zookeeper.default.svc.cluster.local

And that’s the output:

Error: template: storm/templates/nimbus-statefulset.yaml:103:12: executing "storm/templates/nimbus-statefulset.yaml" at <include "common.storage.class" (dict "persistence" .Values.persistence "global" .Values.global)>: error calling include: template: no template "common.storage.class" associated with template "gotpl"

Trying to modify the default values of the chart's yaml and i achieve the same results. Where am i wrong?

My zookeeper is in the same kubernetes cluster (Rancher) deployed via bitnami helm chart and kafka can reach it. maybe the fact that usually "onpremise" zookeeper uses a quorum can be a problem?

Can you provide an example of how to set zookeeper container as disabled and external (but in same kubernetes cluster) zookeeper connection?

Regards

@danielskowronski
Copy link
Contributor

It looks like common.storage.class is defined in https://github.com/bitnami/charts/blob/main/bitnami/common/templates/_storage.tpl

That library is normally loaded as dependency to Zookeeper loaded here:

- name: zookeeper

The problem seems to be that this dependency is loaded based upon zookeeper.enabled flag, so the code always relies on the Bitnami common library, which is only loaded when there's zookeeper loaded.

It looks like the easy fix would be to add new dependency to that shared code in the same way as the actual Zookeeper chart does it:

dependencies:
- name: common
  repository: oci://registry-1.docker.io/bitnamicharts
  tags:
  - bitnami-common
  version: 2.x.x

@danielskowronski
Copy link
Contributor

Issue confirmed to be introduced with chart version 1.0.10, 1.0.9 works fine. It looks like feature was added without a regression test for zookeeper.enabled=false + persistence.enabled=true pair.

Related diff: 86cc090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants