Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to desktop pager #254

Merged
merged 7 commits into from
Feb 2, 2024
Merged

Conversation

andydotxyz
Copy link
Contributor

They fill the space available according to window size.
It fills. Could be adjusted to fit in the center if folk prefer to maintain aspect ratio.

fynedesk-pagericon

Checklist:

  • Tests included. <- Hmm, didn't get this far yet but should be possible
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Jan 21, 2024

Pull Request Test Coverage Report for Build 7616917663

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 28.577%

Totals Coverage Status
Change from base Build 7575318830: -0.1%
Covered Lines: 1576
Relevant Lines: 5515

💛 - Coveralls

@ghost
Copy link

ghost commented Jan 21, 2024

This is a very-exciting PR!

For consistencies sake; It would be neat to still (at least optionally) have numbers drawn over the app-window previews though.

@andydotxyz
Copy link
Contributor Author

For consistencies sake; It would be neat to still (at least optionally) have numbers drawn over the app-window previews though.

I moved the numbers from the button to labels hovering on top. Thanks for the suggestion.

@andydotxyz andydotxyz merged commit 399c17c into FyshOS:develop Feb 2, 2024
5 checks passed
@andydotxyz
Copy link
Contributor Author

No further requests for change in nearly 2 weeks, merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants