Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editor bug] Fonts blurry with display scaling 200% in GNOME using X11 #501

Open
fnune opened this issue Aug 12, 2023 · 6 comments
Open

Comments

@fnune
Copy link

fnune commented Aug 12, 2023

The fonts in the editor look blurry. Note that it's only the fonts: other graphics such as the scene preview and icons scale up properly.

image

Here's a close-up:

image

And here's a comparison with another window with correct scaling:

image

Some information about my system:

 ~/Development/fyrox/game => uname -a
Linux feanor 6.1.0-11-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.38-4 (2023-08-08) x86_64 GNU/Linux

 ~/Development/fyrox/game => gnome-shell --version
GNOME Shell 43.6

 ~/Development/fyrox/game => echo $XDG_SESSION_TYPE
x11
@mrDIMAS
Copy link
Member

mrDIMAS commented Aug 13, 2023

Hi, this is because Fyrox uses bitmap fonts and bakes font atlas in 1:1 ratio.

@fnune
Copy link
Author

fnune commented Aug 13, 2023

I see. Do you think it's feasible to change that?

If I were to take a look at it myself, where should I start?

@mrDIMAS
Copy link
Member

mrDIMAS commented Aug 13, 2023

Hard to tell, the problem is quite complex. At first, when display scaling is applied to the UI, it just scales the geometry of the text (each quad per glyph). This means that the UI does not care what is actually placed on these text quads, it just generates geometry of a proper size. The renderer then using a font atlas to render glyphs. This is where the problem hides - font atlas was generated to 100% display scaling, but used with 200%. So you can begin at https://github.com/FyroxEngine/Fyrox/blob/master/fyrox-ui/src/ttf.rs and try to play with the font atlas bitmap size.

@perry-blueberry
Copy link
Contributor

This seems to be an issue on 100% scaling X11 as well.
image

@DanielJoyce
Copy link

Hmm, so no support for Signed Distance Field fonts?

@mrDIMAS
Copy link
Member

mrDIMAS commented Mar 14, 2024

This issue should be partially fixed by layout rounding feature, that was added recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants