From c81c957204f24c7a87a3241c3b4a79f6e8003d1d Mon Sep 17 00:00:00 2001 From: Steven Hoffman Date: Fri, 31 May 2024 07:55:35 -0700 Subject: [PATCH] use a direct link for records in standings Signed-off-by: Steven Hoffman --- .../templates/components/league_standings.rb | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/lib/baseballbot/templates/components/league_standings.rb b/lib/baseballbot/templates/components/league_standings.rb index a8e9850..76cbabd 100644 --- a/lib/baseballbot/templates/components/league_standings.rb +++ b/lib/baseballbot/templates/components/league_standings.rb @@ -45,7 +45,7 @@ def initialize(subreddit, teams) def to_s rows = %w[West Central East].map do |division| @teams.select { _1.team.dig('division', 'name')[division] } - .map { team_cell(_1) } + .map { "#{team_link(_1)} [#{team_record(_1)}]](/r/#{subreddit_name(_1)})]" } end.transpose table(headers: [['West', :center], ['Central', :center], ['East', :center]], rows:) @@ -53,13 +53,7 @@ def to_s protected - def team_cell(team) - return "#{team_link(team)} [**#{team.wins}-#{team.losses}**][#{team.abbreviation}]" if team.division_champ? - - return "#{team_link(team)} [*#{team.wins}-#{team.losses}*][#{team.abbreviation}]" if team.wildcard_champ? - - "#{team_link(team)} [#{team.wins}-#{team.losses}][#{team.abbreviation}]" - end + def team_cell(team) = "#{team_link(team)} #{team_record(team)}" def team_link(team) return "[#{team.abbreviation}][#{team.abbreviation}]" unless team.wildcard_position @@ -67,6 +61,15 @@ def team_link(team) "[#{team.abbreviation}](/r/#{subreddit_name(team)} \"WC#{team.wildcard_position}\")" end + # We have to use a direct link instead of [][ABBR] because those links have #flair + def team_record(team) + return "**#{team.wins}-#{team.losses}**" if team.division_champ? + + return "*#{team.wins}-#{team.losses}*" if team.wildcard_champ? + + "#{team.wins}-#{team.losses}" + end + def subreddit_name(team) = @subreddit.code_to_subreddit_name(team.abbreviation) # @!group Wildcards