Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: BPM change event #3889

Closed
2 tasks done
amyspark-ng opened this issue Nov 23, 2024 · 5 comments
Closed
2 tasks done

Enhancement: BPM change event #3889

amyspark-ng opened this issue Nov 23, 2024 · 5 comments
Labels
status: duplicate Issue or PR is redundant to another.

Comments

@amyspark-ng
Copy link
Contributor

Issue Checklist

  • I have properly named my enhancement
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested

What is your suggestion, and why should it be implemented?

Why is there not an event to signify bpm changes, i think they're only on metadata but i don't see anything for monster in the chart editor

@amyspark-ng amyspark-ng added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Nov 23, 2024
@Average-FNF-Modder
Copy link

They are currently found manually inside a charts .json (check Monsters .json to see this, it's at the start), though some artwork in the files suggests plans to add an event.
I however have already suggested this in #2911

@Hundrec
Copy link
Collaborator

Hundrec commented Nov 23, 2024

It's quite strange that there is BPM change functionality and an event icon, but still no basic BPM change event with at least one field.

@Average-FNF-Modder
Copy link

It's quite strange that there is BPM change functionality and an event icon, but still no basic BPM change event with at least one field.

For real. I've heard Eric say it's because BPM changes mess up the chart editor often and are very buggy, plus maybe they are planning to implement gradual BPM shifts before they make it an event.

@amyspark-ng
Copy link
Contributor Author

i'll close then

It's quite strange that there is BPM change functionality and an event icon, but still no basic BPM change event with at least one field.

For real. I've heard Eric say it's because BPM changes mess up the chart editor often and are very buggy, plus maybe they are planning to implement gradual BPM shifts before they make it an event.

It is VERY hard to do, however i don't think it's that buggy in the chart editor, at least on monster's, they do have a way to calculate steps properly and it seems to work out fine

@Hundrec Hundrec added status: duplicate Issue or PR is redundant to another. and removed type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. labels Jan 23, 2025
@Hundrec Hundrec closed this as completed Jan 23, 2025
Copy link

This issue is a duplicate. Please direct all discussion to the original issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate Issue or PR is redundant to another.
Projects
None yet
Development

No branches or pull requests

3 participants