Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Screenshot sticks around after exiting the menu it came from (With a suggestion to fix it) #3880

Closed
2 tasks done
sphis-Sinco opened this issue Nov 19, 2024 · 5 comments
Labels
status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.

Comments

@sphis-Sinco
Copy link

Issue Checklist

  • I have properly named my issue
  • I have checked the Issues/Discussions pages to see if my issue has already been reported

Platform

Newgrounds (Web/HTML5)

Browser

None

Version

0.5.3

Description (include any images, videos, errors, or crash logs)

I was making this issue.
#3879 (comment)

And the screenshot stuck around
screenshot-2024-11-19-14-00-11
screenshot-2024-11-19-13-59-52

But something I noticed
is that it doesn't go away when you switch states before it is supposed to fade away.

So yeah.
A recommendation to help fix it would be to have a function for clearing the screenshots when you change states.

So every time you switch to a new state it calls the function and any screenshots that exist are terminated.

(Ignore me bolding the word: terminated. The voices in my head made me do it)

Steps to Reproduce

No response

@sphis-Sinco sphis-Sinco added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. labels Nov 19, 2024
@Hundrec
Copy link
Contributor

Hundrec commented Nov 19, 2024

This has been around for a while, since #2817

@sphis-Sinco
Copy link
Author

This has been around for a while, since #2817

Then im fixing it

@charlesisfeline
Copy link

Then im fixing it

theres already a branch that fixes it in this repo (persistent-screenshot-preview) btw

@sphis-Sinco
Copy link
Author

Then im fixing it

theres already a branch that fixes it in this repo (persistent-screenshot-preview) btw

i figured that out after i rage quit at trying to fix it

@charlesisfeline
Copy link

theres already a branch that fixes it in this repo (persistent-screenshot-preview) btw

i figured that out after i rage quit at trying to fix it

aight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

No branches or pull requests

3 participants