Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jackdaw to work with newer versions of kafka-streams / kafka-streams-test-utils #290

Closed
LouiseKlodt opened this issue May 5, 2021 · 3 comments · Fixed by #292
Closed
Assignees

Comments

@LouiseKlodt
Copy link
Contributor

LouiseKlodt commented May 5, 2021

Currently, the jackdaw.test namespace requires you to import TopologyTestDriver for test-machine to work, which in turn requires you to bring in the org.apache.kafka/kafka-streams-test-utils library as a dependency.

This currently only works using a kafka-streams-test-utils version within 2.0.0 - 2.3.0. When adding versions higher than 2.3.0, it throws errors. For example, for version 2.4.0:

Syntax error (ClassNotFoundException) compiling new at (jackdaw/test.clj:250:5).
org.apache.kafka.streams.internals.QuietStreamsConfig

Errors are thrown for version numbers from 2.4.0, 2.5.0 ... up to the latest: 2.8.0 - they all occur in jackdaw/test.clj.

-> Jackdaw needs to be made compatible / brought up to date with the newest versions from Apache Kafka's libraries.

@LouiseKlodt LouiseKlodt mentioned this issue May 5, 2021
2 tasks
@cddr
Copy link
Contributor

cddr commented May 6, 2021

I think the only thing I needed to do to get it working on later versions of kafka (other than updating dependencies) was to ensure new-topic cast ints to shorts which is required by upstream API now.

https://github.com/cddr/test-machine/compare/75bcf2e..cfab170#diff-c1a95b28cd27156ef869335927cd2bdf20921d544980cf42a11d0740cde7f5a5R22

https://github.com/cddr/test-machine/compare/cfab170..75bcf2e

@gphilipp
Copy link
Contributor

gphilipp commented May 8, 2021

Thanks Andy, we're going to have a look next week.

@gphilipp
Copy link
Contributor

🙋‍♂️ @minimal is going to have a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants