-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disallow dependency package name collision in forc-pkg #6888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #6888 will not alter performanceComparing Summary
|
fb30365
to
45f03d8
Compare
JoshuaBatty
approved these changes
Feb 8, 2025
zees-dev
reviewed
Feb 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
zees-dev
approved these changes
Feb 9, 2025
sdankel
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Description closes #6861 `forc` was allowing dependency name being the same (through the use of `package` alias and the declaration itself) as the project name. The following two cases are now invalid and produces an error on the forc-pkg side before going to the compiler. ```TOML [project] authors = ["Fuel Labs <[email protected]>"] entry = "main.sw" license = "Apache-2.0" name = "lib_contract" [dependencies] lib_contract = { path = "../lib_contract_abi/", package = "lib_contract_abi" } ``` and ```TOML [project] authors = ["Fuel Labs <[email protected]>"] entry = "main.sw" license = "Apache-2.0" name = "lib_contract_abi" [dependencies] lib_contract = { path = "../lib_contract_abi/", package = "lib_contract_abi" } ``` --------- Co-authored-by: Joshua Batty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #6861
forc
was allowing dependency name being the same (through the use ofpackage
alias and the declaration itself) as the project name.The following two cases are now invalid and produces an error on the forc-pkg side before going to the compiler.
and