Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompileError::ContractIdConstantNotAConstDecl #6842

Merged
merged 13 commits into from
Feb 7, 2025

Conversation

mo-hak
Copy link
Contributor

@mo-hak mo-hak commented Jan 18, 2025

Description

In contract_helpers.rs, replaced the ContractIdConstantNotAConstDecl error with an Internal compiler error since this represents an impossible state that should never occur in normal operation.
In error.rs, removed the now unused ContractIdConstantNotAConstDecl error variant and its corresponding span implementation.
The changes make sense because:
The error was only used in one place where it represented an impossible state
If that state is ever reached, it indicates a bug in the compiler itself rather than user error
Using an internal compiler error will make it clearer that this is a compiler bug that needs to be fixed if it ever occurs
fix #6841

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@mo-hak mo-hak requested a review from a team as a code owner January 18, 2025 11:37
@fuel-cla-bot
Copy link

fuel-cla-bot bot commented Jan 18, 2025

Thanks for the contribution! Before we can merge this, we need @mo-hak to sign the Fuel Labs Contributor License Agreement.

jjcnn
jjcnn previously approved these changes Jan 20, 2025
Copy link

codspeed-hq bot commented Jan 20, 2025

CodSpeed Performance Report

Merging #6842 will not alter performance

Comparing mo-hak:master (cbf9f30) with master (0de1c32)

Summary

✅ 22 untouched benchmarks

@JoshuaBatty JoshuaBatty enabled auto-merge (squash) February 7, 2025 02:10
@JoshuaBatty JoshuaBatty merged commit 8696e2c into FuelLabs:master Feb 7, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate CompileError::ContractIdConstantNotAConstDecl
5 participants