-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompileError::ContractIdConstantNotAConstDecl #6842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the contribution! Before we can merge this, we need @mo-hak to sign the Fuel Labs Contributor License Agreement. |
jjcnn
previously approved these changes
Jan 20, 2025
CodSpeed Performance ReportMerging #6842 will not alter performanceComparing Summary
|
IGI-111
reviewed
Jan 21, 2025
jjcnn
approved these changes
Jan 22, 2025
IGI-111
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In contract_helpers.rs, replaced the ContractIdConstantNotAConstDecl error with an Internal compiler error since this represents an impossible state that should never occur in normal operation.
In error.rs, removed the now unused ContractIdConstantNotAConstDecl error variant and its corresponding span implementation.
The changes make sense because:
The error was only used in one place where it represented an impossible state
If that state is ever reached, it indicates a bug in the compiler itself rather than user error
Using an internal compiler error will make it clearer that this is a compiler bug that needs to be fixed if it ever occurs
fix #6841
Checklist
Breaking*
orNew Feature
labels where relevant.