Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination to Account methods #2446

Closed
mvares opened this issue Jun 4, 2024 · 1 comment
Closed

Pagination to Account methods #2446

mvares opened this issue Jun 4, 2024 · 1 comment
Assignees
Labels
feat Issue is a feature

Comments

@mvares
Copy link
Contributor

mvares commented Jun 4, 2024

Each method provides only an array containing their items as a result (e.g., coinsmessages, and balances), and there are some comments in the code marked withto do proposing pagination for the results of these methods. My proposal is:

[{
  page: 1,
  coins: [{ ... }]
},
{
  page: 2,
  coins: [{ ... }] 
}]

Using the example above, too we could apply it to the other methods. Furthermore, maybe creating a reusable helper function would be helpful.

@arboleya arboleya added the feat Issue is a feature label Jun 5, 2024
@arboleya
Copy link
Member

arboleya commented Jun 6, 2024

@arboleya arboleya closed this as completed Jun 6, 2024
@arboleya arboleya self-assigned this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

No branches or pull requests

2 participants