Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add randomUUID into @fuel-ts/crypto #1807

Closed
nedsalk opened this issue Feb 26, 2024 · 5 comments · Fixed by #2903
Closed

Add randomUUID into @fuel-ts/crypto #1807

nedsalk opened this issue Feb 26, 2024 · 5 comments · Fixed by #2903
Assignees
Labels
feat Issue is a feature

Comments

@nedsalk
Copy link
Contributor

nedsalk commented Feb 26, 2024

It's part of both the browser crypto package and the node crypto package, and we're already using it in e.g. launchNode.

@nedsalk nedsalk added the feat Issue is a feature label Feb 26, 2024
@nedsalk
Copy link
Contributor Author

nedsalk commented Feb 28, 2024

For reference, there was already a PR that tried doing this but we didn't go with it: #1608

@danielbate danielbate added the good first issue Suitable for newcomers looking to contribute label Jun 26, 2024
@mvares
Copy link
Contributor

mvares commented Jun 26, 2024

hey @danielbate! I can work on this issue?

@maschad
Copy link
Member

maschad commented Jun 26, 2024

Hey @mvares I see that you currently have two unblocked in-flight PRs

It's best to see those through to completion before beginning any other work.

@mvares
Copy link
Contributor

mvares commented Jun 26, 2024

Hey @mvares I see that you currently have two unblocked in-flight PRs

It's best to see those through to completion before beginning any other work.

Of course! But can you confirm whether this issue is blocked due to this issue or not?

@maschad
Copy link
Member

maschad commented Jun 26, 2024

It's currently not blocked but having read through that PR thread, I'm removing the good first issue because of the work that was involved. Sorry about that.

@maschad maschad removed the good first issue Suitable for newcomers looking to contribute label Jun 26, 2024
@Torres-ssf Torres-ssf added the p2 label Jul 23, 2024
@arboleya arboleya removed the p2 label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants