[Mirror] TOB-FUEL-32: ABI decoder is crashing on certain inputs

[digorithm]

This is a mirror of FuelLabs/fuels-rs#1108.

Opening an issue to investigate these same decoding bugs from the Rust SDK in the Typescript as well.

Trail of Bits (the company doing some audits in our stack) hasn't gone through the TS SDK codebase yet, but some of these problems could also be here; It's worth investigating those proactively.

[arboleya]

@danielbate Could this be the same as the 15th item from this list?

• Feedback - Frontend #1537

[danielbate]

They are definitely related but I think still should to be handled independently, and an exhaustive type checker would be a further iteration IMO.

All of the issues raised by the TOB investigation were regarding input value rather than input type. This would therefore throw in places where the value for a type was not suitable (overflow / underflow / empty). This can be rectified by adding appropriate validation to our coders to ensure they throw gracefully for these scenarios, rather than either panicking or returning an erroneous value. And adding tests to ensure these new validations have been covered.

An exhaustive type checker as mentioned in #1537 should handle values (over / under etc.), but would be an extension to the above by also checking values under certain type combinations, through complex types. Creating a source of truth for types we do and don't handle, and the values we expect returned for them, and at times the validation errors that they may produce.

We could just go straight to the exhaustive type checker, but that would still raise the need for additional validation that this issue is asking for.

[danielbate]

Resolved in #1426