Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve access to witnesses in BlobTransactionBuilder #1578

Open
MujkicA opened this issue Jan 16, 2025 · 0 comments
Open

Improve access to witnesses in BlobTransactionBuilder #1578

MujkicA opened this issue Jan 16, 2025 · 0 comments
Labels
dev-experience enhancement New feature or request

Comments

@MujkicA
Copy link
Contributor

MujkicA commented Jan 16, 2025

Currently, if the user adds a blob via BlobTransactionBuilder::with_blob, the corresponding witness will not be available until .build() is called. This may cause confusion when the user wants to add a predicate which relies on the blob witness to the transaction.

We should attempt to mitigate confusion here, options include setting the witness when with_blob() is called or providing a helper similar to UploadTransactionBuilder::prepare_subsection_upload.

@MujkicA MujkicA added dev-experience enhancement New feature or request labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-experience enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant