Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to make fuels_core WASM compatible? #1005

Open
ra0x3 opened this issue Jun 14, 2023 · 2 comments
Open

Possible to make fuels_core WASM compatible? #1005

ra0x3 opened this issue Jun 14, 2023 · 2 comments
Assignees
Labels
P2 Low priority

Comments

@ra0x3
Copy link

ra0x3 commented Jun 14, 2023

  • On the indexer team we have a really really old bug/hack that we'd like to finally fix
  • The issue is related to some dependency that the indexer uses, pulling in fuel-tx default features
  • On the indexer, we always specify default-features = false for fuel-tx
  • However, due to cargo workspace dependency unification if some other dependency pulls in fuel-tx default features, it doesn't matter that the indexer doesn't directly import fuel-tx default features
    • The default features will still be pulled in, even if any indexer dependency is pulling in the default features
  • As of now, the culprit seems to be fuels_core
  • Is it possible to make fuels_core not pull in these default features from fuel-tx?
  • We won't be able to fix our issue/hack ☝🏽 until this is possible
  • Without fixing this hack, users won't be able to use WASM-friendly crates such as tai64 or chrono - so there's user impact

CC @digorithm @segfault-magnet

@hal3e
Copy link
Contributor

hal3e commented Jun 18, 2023

blocked by: FuelLabs/fuel-vm#443

@xgreenx
Copy link
Contributor

xgreenx commented Sep 27, 2023

Now it is blocked by: FuelLabs/fuel-core#1370

@hal3e hal3e removed the blocked label Oct 19, 2023
@kamyar-tm kamyar-tm added the epic An epic is a high-level master issue for large pieces of work. label Feb 15, 2024
@digorithm digorithm added P2 Low priority and removed epic An epic is a high-level master issue for large pieces of work. labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Low priority
Projects
None yet
Development

No branches or pull requests

5 participants