cargo test with serde added to CI #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this change doesn't make sense on its' own and should be merged into #115 which actually adds the serde feature. |
Voxelot
approved these changes
May 16, 2022
ControlCplusControlV
pushed a commit
that referenced
this pull request
Nov 24, 2022
The input coin defined in the specifications is an aggregated type between two logical variants: signed and predicate. When the input is expected to behave as coin, the signature validation should seek its witness counterpart and check the signature with its fields as arguments = except for predicate and its data. When the input is expected to behave as predicate, the validation will check if the owner is the hash of the predicate. The witness id is entirely ignored. It is canonical to Rust to split these two different logical structures into different enum variants - even if we are to maintain the fuel specs canonical serialization. Closes #110
ControlCplusControlV
pushed a commit
that referenced
this pull request
Dec 1, 2022
The input coin defined in the specifications is an aggregated type between two logical variants: signed and predicate. When the input is expected to behave as coin, the signature validation should seek its witness counterpart and check the signature with its fields as arguments = except for predicate and its data. When the input is expected to behave as predicate, the validation will check if the owner is the hash of the predicate. The witness id is entirely ignored. It is canonical to Rust to split these two different logical structures into different enum variants - even if we are to maintain the fuel specs canonical serialization. Closes #110
xgreenx
pushed a commit
that referenced
this pull request
Dec 20, 2022
The input coin defined in the specifications is an aggregated type between two logical variants: signed and predicate. When the input is expected to behave as coin, the signature validation should seek its witness counterpart and check the signature with its fields as arguments = except for predicate and its data. When the input is expected to behave as predicate, the validation will check if the owner is the hash of the predicate. The witness id is entirely ignored. It is canonical to Rust to split these two different logical structures into different enum variants - even if we are to maintain the fuel specs canonical serialization. Closes #110
xgreenx
pushed a commit
that referenced
this pull request
Dec 20, 2022
The input coin defined in the specifications is an aggregated type between two logical variants: signed and predicate. When the input is expected to behave as coin, the signature validation should seek its witness counterpart and check the signature with its fields as arguments = except for predicate and its data. When the input is expected to behave as predicate, the validation will check if the owner is the hash of the predicate. The witness id is entirely ignored. It is canonical to Rust to split these two different logical structures into different enum variants - even if we are to maintain the fuel specs canonical serialization. Closes #110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #116