Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AppendReceipt to limit the total number of possible receipts to u16::MAX #620

Closed
xgreenx opened this issue Oct 30, 2023 · 0 comments · Fixed by #633
Closed

Update AppendReceipt to limit the total number of possible receipts to u16::MAX #620

xgreenx opened this issue Oct 30, 2023 · 0 comments · Fixed by #633
Assignees
@Dentosal
Labels
breaking A breaking api change

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Oct 30, 2023 •
edited
Loading

Overview

We want to limit the maximum supported number of receipts to u16::MAX.

It requires updating the specification and highlighting that when the number of receipts hits u16::MAX, the corresponding opcode fails the execution.

Implementation details

The AppendReceipt::push should return a Result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dentosal Dentosal

Labels
breaking A breaking api change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limit ReceiptsCtx to u16::MAX receipts FuelLabs/fuel-vm
2 participants
@Dentosal @xgreenx