Zero all malleable fields before execution #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it makes sense to remove the getter for malleable fields since they are zero all the time. We don't need to change the discriminant for values, we can leave gaps |
|
Before merging this PR, I would suggest doing FuelLabs/fuel-core#1620 first. It will help identify all problematic fields. Maybe we missed something here |
|
CI not passing due to #547 |
Voxelot
reviewed
Feb 19, 2024
Voxelot
previously approved these changes
Feb 21, 2024
|
For future reference, removing the intermediate receipt roots is possible now that we are going with a zk-hybrid proving approach. |
xgreenx
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #542.
Also changes
tx.receiptsRootto only be updated after the tx has terminated, as the intermediate values are no longer useful. The speeds up and simplifies implementation of receipt-pushing opcodes.