This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enhancement: WASM error codes, early exit on error or kill switch #1337
enhancement: WASM error codes, early exit on error or kill switch #1337
Changes from 11 commits
21e2e2f
e74645e
92e0139
69ca4bf
1b2318d
712b489
018981f
969be90
b17177f
63920fa
a73f591
1dc9f5f
4cff8b3
a6d3d88
0af2583
a4549a8
46507e8
c295242
18f5bd3
a00ca22
0de8632
146798c
0baa5a4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.expect
) as close to the actual culprit call as possiblefuel_indexer::database::Database:: put_many_to_many_record
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error is handled in
put_many_to_many_record
. In WASM, it is a host function that returnsResult<>
, which triggers early termination.The code here is for native execution. This
expect
achieves an equivalent behavior.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here:
.expect
) as close to the actual culprit call as possiblefuel_indexer::database::Database:: put_object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error is handled in
put_object
. In WASM, it is a host function that returns Result<>, which triggers early termination.The code here is for native execution. This expect achieves an equivalent behavior.