Add support for ConsensusParametersVersion::V2

[rafal-ch]

Partial implementation of #2133.

Linked Issues/PRs

(FuelLabs/fuel-vm#821)

Description

It adds handling for the updated data struct ConsensusParameters (new field: block_transaction_size_limit). No additional logic around this new parameter is implemented in this PR, it's just a stub for further work.

The new parameter is exposed via GraphQL, example:

Request snippet:

  consensusParameters(version: 0) {
    blockGasLimit
    blockTransactionSizeLimit
  }

Response snippet:

  "consensusParameters": {
    "blockGasLimit": "30000000",
    "blockTransactionSizeLimit": "129024"
  }

Checklist

• Breaking changes are clearly marked as such in the PR description and changelog
• New behavior is reflected in tests
• The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

• I have reviewed the code myself
• I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

• Rust SDK
• Sway compiler
• Platform documentation (for out-of-organization contributors, the person merging the PR will do this)
• Someone else?

[acerone85]

When I run the node and make the following query:

curl -X POST http://localhost:4000/v1/graphql \
-H "Content-Type: application/json" \
-d '{
    "query": "{ consensusParameters(version:0) { version blockGasLimit blockTransactionSizeLimit } }"
}'

I get the following result

{
  "data": {
    "consensusParameters": {
      "version": "V2",
      "blockGasLimit": "30000000",
      "blockTransactionSizeLimit": "129024"
    }
  }
}

Is this the expected result? I would imagine that by querying consensusParameters(version:0) we got still the V1 parameters, and to get the V2 consensus parameters we would need to run a query with consensusParameters(version:1).

Or am I missing something?

[rafal-ch]

When I run the node and make the following query:

curl -X POST http://localhost:4000/v1/graphql \
-H "Content-Type: application/json" \
-d '{
    "query": "{ consensusParameters(version:0) { version blockGasLimit blockTransactionSizeLimit } }"
}'

I get the following result

{
  "data": {
    "consensusParameters": {
      "version": "V2",
      "blockGasLimit": "30000000",
      "blockTransactionSizeLimit": "129024"
    }
  }
}

Is this the expected result? I would imagine that by querying consensusParameters(version:0) we got still the V1 parameters, and to get the V2 consensus parameters we would need to run a query with consensusParameters(version:1).

Or am I missing something?

My explanation would be that since the chain starts-up at genesis with this change in the chainspec config included, it treats this as "version 0", aka "the first (zero-indexed) and only version known".

I assume that if we had started with the original chainspec containing V1, this V1 would become a version 0. And later if we upgrade the network to V2, this V2 would actually become version 1.

I not super certain this is the expected/correct behavior, though.

[acerone85]

Thanks for explaining. Overall LGTM. I'll just wait for somebody to confirm that the behaviour re the version is correct, and that the breaking changes to fuel-vm are merged. After that I will be happy to approve.

[AurelienFT]

Looks good to me, however I don't feel confortable approving this as I barely understand why each changes has been done.

[AurelienFT]

This description shouldn't be in this PR.

[rafal-ch]

True, it's not necessarily a part of the feature being implemented in this PR, but the breaking changes was pulled into this branch here and here, so technically, this message belongs here.

I'll most likely not merge this PR before the one which contained the original change is merged first.

[AurelienFT]

When I first read it, I understood that it was the maximum size for a transaction. I think I misunderstood because the word transaction is singular. IMO, it should be plural.

[rafal-ch]

Yes, the name could indeed be slightly improved. However, it's already merged in fuel-vm here.

In the follow-up PR to fuel-core I'll make sure that this is comprehensively documented.

[rafal-ch]

Looks good to me, however I don't feel confortable approving this as I barely understand why each changes has been done.

It'll get more clear after #2199 is merged.

[Dentosal]

Sorry about the accidental merge. Feel free to revert if needed.