Release/0.20.7 *do not merge* #1425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: #1421 --------- Co-authored-by: xgreenx <[email protected]>
…reasing (#1423) Closes #1384 After debugging the issue with transaction broadcasting in the Beta 4 network, I can confirm that it is related to the gossipsub reputation. At some point, no one sends transactions to the authority node. When I manually restart one sentry node, this node starts to send transactions to the authority node. It sends transactions via gossiping and publishing: - Publishing: I send a transaction to sentry 1, which sends it to authority. - Gossiping: I send the transaction to sentry 0, it sends the transaction to sentry 1, and it sends the transaction to authority. But at some point, gossiping doesn't work while publishing still works(Sentry 0 gossips transaction to Sentry 1, and Sentry 1 doesn't gossip it to authority). After some time, the publishing doesn't work either. The gossipsub has two thresholds, one for gossiping and one for publishing. We use these values: <img width="652" alt="image" src="https://github.com/FuelLabs/fuel-core/assets/18346821/bcb1585c-239b-4cf9-9fae-c9376b958201"> So, the described behavior aligns with authority reputation decreasing. I don't know the reason why it happens(maybe decay), but adding all reserved peers to explicit peers should solve the problem.
|
It is released https://github.com/FuelLabs/fuel-core/releases/tag/v0.20.7, so we can close the PR=) |
|
This problem is very significant, and we hope to close it down as soon as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the planned hotfixes for beta4, this PR isn't intended to be merged, but just to run a full CI pass on all the changes together.
includes:
#1422
#1423