Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement query & depth restrictions on the GQL interface #1651

Closed
Voxelot opened this issue Feb 8, 2024 · 0 comments · Fixed by #1676
Closed

Implement query & depth restrictions on the GQL interface #1651

Voxelot opened this issue Feb 8, 2024 · 0 comments · Fixed by #1676
Assignees

Comments

@Voxelot
Copy link
Member

Voxelot commented Feb 8, 2024

Overview

Currently, GraphQL queries are unlimited in depth and complexity. It is possible to request all blocks with all transactions and receipts in one query causing OOM on the fuel-core node(plus it consumes a lot of execution).

Solution

We need to implement limits on the complexity and depth of graphql queries to protect the APIs from DOS attacks. This will need to be done carefully, ensuring that the SDK isn't rendered unusable by excessive limits.

Implementation details

https://async-graphql.github.io/async-graphql/en/depth_and_complexity.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants