Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standarize file and function names #8

Open
Frostbyte0x70 opened this issue Dec 13, 2023 · 0 comments
Open

Standarize file and function names #8

Frostbyte0x70 opened this issue Dec 13, 2023 · 0 comments

Comments

@Frostbyte0x70
Copy link
Owner

Names for files and functions are a mess right now. Some files are named in PascalCase, some in camelCase. Some functions are prefixed by fn_, some are not, some have a name that doesn't match their pmdsky-debug names... All of this should be standarized.

  • Use PascalCase for all the .asm files. Check if this change requires changes in SkyTemple's patch definitions.
  • Remove the fn_ prefix from all the function labels.
  • Check for functions that are already documented in pmdsky-debug and rename them to match the name they have there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant