DX: relax composer requirements to not block installation under PHP v8, support for PHP v8 is not yet ready #5326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8, support for PHP v8 is not yet ready
kubawerlos
approved these changes
Dec 7, 2020
keradus
force-pushed
the
2.17_relax_composer_reqs
branch
from
c566e41 to
e393d52
Compare
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state:
Actually, not every user is using the composer.json file, thus we need a requirements check on runtime, and that can actually be good as only checker.
For that, we decided to relax the requirements in composer.json file.
Dropping
<8from composer.json file DOES NOT MEAN we support PHP v8, it is still ongoing effort.Until PHP v8 is not fully supported and support is claimed in bootstrap file, PHP tokenizer for new PHP syntax can introduce new custom tokens, to ease handling of new syntax by the tool and rules we have.