-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DX: Test that Transformers are adding only CustomTokens that they define and nothing else #5500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
changed the title
2.18 custom tokens
DX: Test that Transformers are adding only CustomTokens that they define and nothing else
Feb 17, 2021
…ine and nothing else
keradus
force-pushed
the
2.18_CUSTOM_TOKENS
branch
from
March 1, 2021 09:29
635068c
to
9f54f1b
Compare
17 tasks
This was referenced Mar 11, 2021
Merged
Closed
This was referenced Mar 11, 2021
Closed
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transformer classes are internal, so we can do whatever we want there without BC promise and upcoming BC breaks warnings.
Let's use the
getCustomTokens
method to ensure that Transformer is adding only allowed custom tokens, and no other transformer is adding them.Unfortunately, to implement this check i had to bypass few things (eg access internals), but I couldn't find a good way to do it without refactoring main Tokenizer class into first-class service.